[WIP] Move time source from db layer to PersistenceManager #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribaraka
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
bowenxia
reviewed
Jan 28, 2025
| @@ -60,7 +60,7 @@ func TestNosqlExecutionStoreUtils(t *testing.T) { | |||
| Data: []byte(`[{"Branches":[{"BranchID":"test-branch-id","BeginNodeID":1,"EndNodeID":2}]}]`), | |||
| }, | |||
| } | |||
| return store.prepareCreateWorkflowExecutionRequestWithMaps(workflowSnapshot) | |||
| return store.prepareCreateWorkflowExecutionRequestWithMaps(workflowSnapshot, time.Now()) | |||
There was a problem hiding this comment.
Have you had any error when running the unit tests? I was thinking to use a constant time stamp in the tests like this so that in the unit tests it will always keep the same
There was a problem hiding this comment.
No, there haven't been any errors in the tests with this implementation. However, I refactored it to use a FixedTime variable for consistency.
ribaraka
force-pushed
the
mv-timeSrc-to-persistManager
branch
from
e99014a to
f1bb070
Compare
|
@bowenxia added another commit with a refactor of the history storage. If you have time, please take a look. I'll be sending the work in small chunks, little by little. There are a few TODOs— if you could reply to them, I’d really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the system so that the PersistenceManager level handles the timestamp
Why?
#6610
How did you test it?
unit tests
Potential risks
Release notes
Documentation Changes