-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding callsites #97
base: main
Are you sure you want to change the base?
Conversation
we will need to refactor this back to use dyninst master, I have changed a bunch to use a development build/container. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
@hainest refactor done to remove inline and try to reduce redundancy of function! I think we probably need to be passing the allocator from the top level function and use reference/pointer to save state but I wasn't sure how to do that (do we need to change the classify template thing?) I might need some pointers for how to do that because what I tried didn't work! |
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
cf. return values at callsite: DW_AT_callsite does not have return type information. Dyninst can produce return type info iff the called function points to an already-parsed function (this is a limitation of the current Dyninst DWARF parser). Can Smeagle check if there is a function declaration that matches the called function in the current CU? If so, we can match params based on that. |
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
@hainest I've added most of what Jim shared, but Smeagle-ized. This cannot be merged / added until:
So I'm tagging WIP for now before we discuss this, and we won't merge obviously until it's added to dyninst proper and I can revert back the original build (Dockerfile, etc.).