e2e: Added tests for Jsonnet and file rendering. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bartlomiej Plotka <[email protected]>
brancz
approved these changes
Apr 20, 2022
|
We use this project in production so it's not dead at all, it was just doing exactly what we've needed for the last ~1.5years. But definitely happy to collaborate! |
brancz
reviewed
Apr 20, 2022
| // TestFileExampleRender tests locutus in docker rendering of examples in `/example/files` directory. | ||
| // This e2e tests require `make docker` first. | ||
| func TestFileExampleRender(t *testing.T) { | ||
| e, err := e2e.NewDockerEnvironment("e2e_file") |
There was a problem hiding this comment.
Does this really need to run in docker?
There was a problem hiding this comment.
I get that an e2e test for the kubernetes functionality should run on Kubernetes, but everything else should just be plainly run on the machine, no?
There was a problem hiding this comment.
Yea, well, my arguments were:
- The direct usage of Locutus is primarily through containers, so we test more by using the docker image directly
- We have a ready testing framework for docker that is consistently used across all our project
- Running full Kubernetes just to test Locutus sounds like overkill, plus it's hard to find CI for running Kubernetes for tests purposes (reliable one and ideally free/cheap).
But yea, happy to discuss - you would prefer using os.Exec?
There was a problem hiding this comment.
yeah I think I would prefer os.Exec
Signed-off-by: Bartlomiej Plotka <[email protected]>
|
Also see next idea: #50 - to see if we agree on common direction of Locutus - I think there is overlap (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to revive this project a bit as we depend on it in Observatorium, plus experimenting with potential further use. (:
cc @brancz - let us know if you want our team to maintain this project / fork if we want to continue development - let us know your preference (:
Signed-off-by: Bartlomiej Plotka [email protected]