Get the correct username from the page URL, rather than extracting it from HTML #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should be both more reliable, and stable (particularly when mastodon instances use custom themes, or a new mastodon version changes the HTML).
It also addresses #3: The reason this one isn't working, is because hachyderm doesn't always have the
meta[property="profile:username"]
element on the page.I have left the previous mechanism to extract the username from the HTML in place, because it might be useful for instances that have changed the URL scheme (e.g. by removing the
@
from the url) although I personally haven't seen any.