Conversion logging #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girving
suggested changes
Mar 28, 2017
| @@ -3650,7 +3650,7 @@ let PICK = prove | |||
| REWRITE_TAC[SET_RULE | |||
| `{x | x IN (s UNION t) /\ P x} = | |||
| {x | x IN s /\ P x} UNION {x | x IN t /\ P x}`] THEN | |||
| (CONV_TAC o GEN_SIMPLIFY_CONV TOP_DEPTH_SQCONV (basic_ss []) 5) | |||
| ((CONV_TAC "o") o GEN_SIMPLIFY_CONV TOP_DEPTH_SQCONV (basic_ss []) 5) | |||
There was a problem hiding this comment.
This one isn't reasonably matched, though I'm not sure how it'd be covered by this technique.
| @@ -143,7 +143,7 @@ let sexp_tactic_log taclog = | |||
| Fake_log -> simple "Fake_log" | |||
| | Label_tac_log (st, th) -> Snode [Sleaf "Label_tac_log"; Sleaf st; sexp_thm th] | |||
| | Accept_tac_log th -> thm "Accept_tac_log" th | |||
| | Conv_tac_log c -> Snode [Sleaf "Conv_tac_log"; sexp_conv c] | |||
| | Conv_tac_log (s, c) -> Snode [Sleaf "Conv_tac_log"; Sleaf s; sexp_conv c] | |||
There was a problem hiding this comment.
This will break any S-expr parser that we write, since the leaf strings aren't escaped. Let's leave it out for now.
| @@ -0,0 +1,52 @@ | |||
| def next_nonspace(s, i) | |||
There was a problem hiding this comment.
How does conv_tac_params.rb differ from match_paren.rb?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to trace the parameter of CONV_TAC as a string for a first iteration of tracking conversions. The parameter of CONV_TAC is stored in the proof log.