Make the plugin Chef 11 compatible

[gregkare]

• Removed unused require (that's lucky, since Chef 11 doesn't have that class anymore)
• Allow any version between 10.14 that's smaller than 12

I'm not sure about pinning the version to < 12, maybe it would be safer to set it to the latest 11 version. But then you have to create a new version for every new chef release...

What do you think?

[gregkare]

I forgot to mention that I've tried this modified version with both Chef 11.4.0 and 10.24.0: I got the specs to pass and used it on one of my infrastructures.

Edit: Just seen you're already using Travis, I've added an initial .travis.yml file with multiple Chef versions.

[gregkare]

Hey, did you take a look at this?

[meatballhat]

If this is all it takes, then 👍

The testing-specific bits in the gemspec feel slightly icky, but it's not horrible 😸

[gondoi]

👍

[gregkare]

I've added more Chef versions, specs are all green: https://travis-ci.org/bmarini/knife-inspect/builds/10490378

Time to merge this? :)

[bmarini]

Dan, I made you a collab. I haven't been using Chef lately day to day and
you are probably in a better position to maintain this (if you want).

On Thu, Aug 22, 2013 at 4:08 AM, Greg Karékinian
[email protected]:

I've added more Chef versions, specs are all green:
https://travis-ci.org/bmarini/knife-inspect/builds/10490378

Time to merge this? :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-23082563
.

*----
Ben Marini | ENGINEER

Remind101.com https://www.remind101.com/ |
BLOGhttp://blog.remind101.com/ | FOLLOW
US https://twitter.com/remind101 | LIKE
UShttps://www.facebook.com/remind101
*

[meatballhat]

Merged! Thanks, Ben 😸

[gregkare]

@meatballhat @bmarini Is there a plan to release a new gem version that includes the Chef 11 compatibility?

Looks like you can make someone a new owner with gem owner knife-inspect --add <dans_email_address>

[gregkare]

@bmarini I would gladly take over knife-inspect if @meatballhat doesn't want to. I want to release a version that includes Chef 11 support and proper exit codes #14, fix/close all the remaining issues, and then spend some to improve the code gradually.

What do you think?

[meatballhat]

@gregkare Sorry about the delay! I'm 👍 for you taking over given knife-inspect is no longer part of my workflow. @bmarini What do you think about transferring ownership?

[gregkare]

@bmarini Have you thought about transferring the gem over to me? Thanks a lot for creating knife-inspect, I think it can still be useful to many people.

[sjourdan]

I, for one, am highly interested in a working gem version for easy deployment. I use knife-inspect daily in my workflow. Thanks @gregkare for proposing the takeover!

[bmarini]

@gregkare Sorry also for not responding sooner. I'd be happy to have you take over! Let me see about giving you the keys.

[bmarini]

@gregkare I made you a collab and also owner for the gem. Take care of her for me :)

[gregkare]

Thanks a lot, I will!