Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[IT]: CSL+FSM together or both disabled; rollback new python features #592

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jan 31, 2025

  • Rollback new python features (int | None with |-notation, replaced by Optional[int]) blocking us from launching ITs on older python versions
  • Redo ITs launch presets, by allowing CSL+FSM together only or both disabled

@678098 678098 requested a review from a team as a code owner January 31, 2025 11:00
@678098 678098 force-pushed the 250131_rollback_new_python_features branch from ccaa6ab to 9e23353 Compare January 31, 2025 11:01
@678098 678098 force-pushed the 250131_rollback_new_python_features branch from 9e23353 to 4334a6e Compare January 31, 2025 12:12
@678098 678098 requested a review from pniedzielski January 31, 2025 13:00
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@678098 678098 merged commit 7b30704 into bloomberg:main Feb 4, 2025
26 of 29 checks passed
@678098 678098 deleted the 250131_rollback_new_python_features branch February 4, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants