Fix mqbblp::RecoveryManager: Clear sync peer promptly #589
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can ignore IncoreCSL unit test failure. Will be fixed in another branch |
kaikulimu
requested review from
dorjesinpo
and removed request for
chrisbeard
kaikulimu
requested review from
chrisbeard
and removed request for
dorjesinpo
dorjesinpo
reviewed
Feb 5, 2025
There was a problem hiding this comment.
This logs source twice (instead of primarySyncPeer):https://bbgithub.dev.bloomberg.com/BMQ/blazingmq-mirror/blob/85fa14b429195474314a4fc1675b5bc923099a6e/src/groups/mqb/mqbblp/mqbblp_storagemanager.cpp#L813
Can we document/comment somewhere how do RecoveryManager_PrimarySyncContext::primarySyncInProgress() and RecoveryManager_PrimarySyncContext::syncPeer() relate? What are the scenarios when one is 0 and the other is not (if any)?
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
Signed-off-by: Yuan Jing Vincent Yan <[email protected]>
kaikulimu
force-pushed
the
resetSyncPeer
branch
from
313caff to
f4cbbb6
Compare
|
@dorjesinpo Added some explanation. Hope that clears things up. |
kaikulimu
changed the title
kaikulimu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See internal ticket 178057288
Clearing sync peer promptly prevents this failure condition to trigger when the sync peer node goes down after sync with that peer is already complete. Otherwise, we will call
onPartitionPrimarySyncStatus(partitionId, -1 /* status */);and fail this assert later on because primary is already active.