fix: mix of strong and weak consistencies #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaly Dzhitenov <[email protected]>
kaikulimu
reviewed
Dec 21, 2023
Signed-off-by: Vitaly Dzhitenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a partition hosts both weak and strong consistencies and there are recovered messages and the last recovered messages is of weak consistency, replica can issue implicit receipt for the weak consistency GUID. Primary will ignore that receipt because the collection of unreceipted messages is hashtable, not a map (for performance reasons). (Primary will process next ones).
Solution is to make sure implicit receipt is for the last strong consistency GUID.
This fix needs manual merge into the future FSM flow.