Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues #664

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix some issues #664

wants to merge 3 commits into from

Conversation

DRSchlaubi
Copy link

  • Fix missing openapi version field
  • Fix json schema field missing
  • Fix broken path calculation of NotarizedResource

Description

This PR fixes the following issues

  • swagger throws a parser error, when the openapi field is not serialized
  • NotarizedResource currently uses its own route calculation logic, which seems to be broken, instead of /music/auth/exchange it calculated //musicauthexchange

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Chore

How Has This Been Tested?

Create new unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated the CHANGELOG in the Unreleased section
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DRSchlaubi
Fix some issues
7f22e94 
- Fix missing openapi version field
- Fix json schema field missing
- Fix broken path calculation of NotarizedResource
@DRSchlaubi
Add changelog
9a44e8c
@DRSchlaubi
Fix missing types for security schemes
e9bb5a6
@ezienecker
Copy link

@brizzbuzz When is the fix planned for? I can confirm the bug that is being fixed here in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DRSchlaubi @ezienecker