Added SHA256 digest support to the helm deployment template #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chandu Paladugu <[email protected]>
…L36 and L44 Signed-off-by: Chandu Paladugu <[email protected]>
devopstoday11
requested review from
alvneiayu and
agarcia-oss
as code owners
devopstoday11
changed the title
alvneiayu
requested changes
Dec 5, 2024
| ## @param image.pullPolicy Sealed Secrets image pull policy | ||
| ## @param image.pullSecrets [array] Sealed Secrets image pull secrets | ||
| ## | ||
| image: | ||
| registry: docker.io | ||
| repository: bitnami/sealed-secrets-controller | ||
| tag: 0.27.2 | ||
| #digest: "" |
There was a problem hiding this comment.
Please uncomment this, no need to comment it. Just define it with the empty ""
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Due to the lack of activity in the last 7 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add SHA256 digest support to the deployment template and add the "digest" parameter to values.yaml
Benefits
It is easy to pull images with specific SHA digest values when the need arises.
Possible drawbacks
We used it in our production environment for a while and haven't seen any drawbacks yet.
Additional information
The deployment template update to support the SHA digest helped us explicitly specify the SHA digest for particular architecture-based images when facing issues in the cluster that are irrelevant to sealed secrets and image pull. Having the SHA digest support helped us not have a roadblock to deploying and using sealed secrets smoothly. So, I am sharing the update we did and used with the community.