Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Check for ServiceMonitor apiVersion capabilities #1457

Closed
wants to merge 2 commits into from

Conversation

wsn-dev
Copy link

@wsn-dev wsn-dev commented Feb 12, 2024

Description of the change

In an Kubernetes as a Service Environment the values.yaml for the sealed-secrets are predefined.
This means also that the Monitoring is enabled by default.
Enabling the ServiceMonitor and not have the kube-prometheus-stack in place leads to issues installing this chart.
The kube-prometheus-stack releates on some pre defined secrets thats why the sealed-secrets deployment is needed before the kube-prometheus-stack.
Also enabling and disabling this leads to some commits in an gitops approach way.
Thats why i would like to have this capabilities check in place.

Benefits

The ServiceMonitor is not applyed unless the approappropriate crd is installed.

Possible drawbacks

helm template will not render the ServiceMonitor object if it does not know about this api capabilities or the --validate flag is not provided.

Signed-off-by: Jan Mitterle <[email protected]>
@agarcia-oss
Copy link
Member

Hi @wsn-dev thanks for the contribution, but we cannot merge the changes.

These same changes were proposed in the past and we think they will cause helm template issues as you commented in the PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants