-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electrum 4.0.3 upgrade and 1.0 release #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 336 330 -6
=========================================
- Hits 336 330 -6
Continue to review full report at Codecov.
|
xiaoxianma
approved these changes
Sep 13, 2020
15 tasks
Breaking changes since last electrum version, documented here (for changelog):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes necessary changes to SDK to work with electrum 4.0
Daemon PR: bitcart/bitcart#123
Some changes in SDK in this PR:
onchain_history
now doesn't need to be json.load'ed, this bug was fixed. SDK update will make it seamlessaddinvoice
renamed toadd_invoice
(breaking)poll_updates
timeout before re-fetching new updates decreased from 2 to 1 secondBreaking changes since last electrum version, documented here:
pay_to
/pay_to_many
, with broadcast=False now returns str instead of a dict, removing redundant keys. It now returns raw transaction directly.add_invoice
now returns a dictionary instead of strBefore it returned lightning invoice itself, now it returns payment request dict for lightning, where invoice is in
invoice
keydict structure:
timestamp
key (int),rhash
(str) andinvoice
(str)errors.LightningUnsupportedError
will be raised nowadd_request
/get_request
structure changed:memo
key renamed tomessage
(payment request description)amount
key toamount_sat
(amount in satoshis)is_lightning
key, which will beFalse
on payment requestsget_tx
output format changed:partial
andsegwit_ser
keyslockTime
renamed tolocktime
coinbase
key (bool)sequence
tonsequence
type
,address
andnum_sig
keysscriptPubKey
renamed toscriptpubkey
value
renamed tovalue_sats
prevout_n
andtype
keyslist_channels
output format changed:channel_id
renamed toshort_channel_id
full_channel_id
renamed tochannel_id
peer_state
key (str)local_htlcs
andremote_htlcs
local_reserve
(int),remote_reserve
(int),local_unsettled_sent
(int) andremote_unsettled_sent
(int) keyslnpay
output changed:NoPathFoundError
or any other errors anymoresuccess
(bool),preimage
(Optional[str]) andlog
(list of lists of strings)Some current issues:
Failed to verify our signature
, only force-close works. (done)TODO: