Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

True Global #86

Merged
merged 2 commits into from
Mar 27, 2016
Merged

True Global #86

merged 2 commits into from
Mar 27, 2016

Conversation

blond
Copy link
Member

@blond blond commented Mar 27, 2016

Resolved #85

blond added 2 commits March 27, 2016 23:17
fix(global): use window and global instead of this
b31f3c0 
Now to provide `bemNaming` to global scope using `this`.

In NodeJS `this` link to `module.exports`, but not in `global`
variables.

For browsers need use `window` variable.
style(browser): add browser env for eslint
4c26980
@blond blond merged commit 21ead41 into master Mar 27, 2016
@blond blond deleted the issue-85 branch March 27, 2016 20:42
qfox pushed a commit that referenced this pull request Jun 6, 2017
@greenkeeperio-bot @blond
chore(package): update nyc to version 9.0.1 (#86)
0707223 
https://greenkeeper.io/
qfox pushed a commit that referenced this pull request Jun 6, 2017
@blond
Merge pull request #86 from bem-sdk/greenkeeper/sinon-2.0.0
c65b278 
Update sinon to the latest version 🚀
@qfox qfox added the pkg:naming label Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg:naming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blond @qfox