chore(ci): remove JS blocks in workflow conditionals (#2259)

bcgov · Jan 28, 2025 · 1f86191 · 1f86191
1 parent 8039170
commit 1f86191
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/.deployer-db.yml b/.github/workflows/.deployer-db.yml
@@ -58,7 +58,7 @@ on:
 jobs:
   deploy_db:
     runs-on: ubuntu-24.04
-    if: ${{ inputs.enabled }}
+    if: inputs.enabled
     name: Crunchy (db)
     environment: ${{ inputs.environment }}
     steps:

diff --git a/.github/workflows/.tests.yml b/.github/workflows/.tests.yml
@@ -70,7 +70,7 @@ jobs:
           npx playwright test --project="${{ matrix.project }}" --reporter=html
 
       - uses: actions/upload-artifact@v4
-        if: ${{ !cancelled() }}
+        if: (! cancelled())
         name: upload results
         with:
           name: playwright-report-${{ matrix.project }}

diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml
@@ -18,7 +18,7 @@ permissions: {}
 jobs:
   tests:
     name: Tests
-    if: ${{ ! github.event.pull_request.draft }}
+    if: (! github.event.pull_request.draft)
     runs-on: ubuntu-24.04
     timeout-minutes: 5
     services:
@@ -62,7 +62,7 @@ jobs:
   # https://github.com/marketplace/actions/aqua-security-trivy
   trivy:
     name: Trivy Security Scan
-    if: ${{ ! github.event.pull_request.draft }}
+    if: (! github.event.pull_request.draft)
     permissions:
       security-events: write
     runs-on: ubuntu-24.04

diff --git a/.github/workflows/demo.yml b/.github/workflows/demo.yml
@@ -19,7 +19,7 @@ permissions: {}
 jobs:
   demo-routing:
     name: DEMO Routing
-    if: ${{ github.event_name == 'workflow_dispatch' || github.event.label.name == 'demo' }}
+    if: github.event_name == 'workflow_dispatch' || github.event.label.name == 'demo'
     env:
       DEST: demo
       DOMAIN: apps.silver.devops.gov.bc.ca

diff --git a/.github/workflows/notifications.yml b/.github/workflows/notifications.yml
@@ -17,11 +17,11 @@ jobs:
       - run: echo "${{ vars.MS_TEAMS_WEBHOOK_URI }}"
 
   notify-teams-pr:
-    if: ${{github.event.workflow_run.event == 'pull_request' && vars.MS_TEAMS_WEBHOOK_URI != null}}
+    if: github.event.workflow_run.event == 'pull_request' && vars.MS_TEAMS_WEBHOOK_URI != null
     runs-on: ubuntu-24.04
     steps:
       - uses: simbo/msteams-message-card-action@latest
-        if: ${{ vars.MS_TEAMS_WEBHOOK_URI != null}}
+        if: vars.MS_TEAMS_WEBHOOK_URI != null
         with:
           webhook: ${{ vars.MS_TEAMS_WEBHOOK_URI }}
           title: "${{github.event.workflow_run.head_commit.message}}" 
@@ -38,11 +38,11 @@ jobs:
                 image: ${{github.event.workflow_run.head_repository.owner.avatar_url}}
                 text: PR Opened
   notify-teams-merged:
-    if: ${{github.event.workflow_run.event == 'push' && vars.MS_TEAMS_WEBHOOK_URI != null}}
+    if: github.event.workflow_run.event == 'push' && vars.MS_TEAMS_WEBHOOK_URI != null
     runs-on: ubuntu-24.04
     steps:
       - name: PR Number
-        if: ${{ vars.MS_TEAMS_WEBHOOK_URI != null }}
+        if: vars.MS_TEAMS_WEBHOOK_URI != null
         id: pr
         shell: bash
         run: |
@@ -59,7 +59,7 @@ jobs:
           fi
           echo "pr=${pr}" >> $GITHUB_OUTPUT
       - uses: simbo/msteams-message-card-action@latest
-        if: ${{ vars.MS_TEAMS_WEBHOOK_URI }}
+        if: vars.MS_TEAMS_WEBHOOK_URI
         with:
           webhook: ${{ vars.MS_TEAMS_WEBHOOK_URI != null }}
           title: "${{github.event.workflow_run.head_commit.message}}"