feat(FSADT1-1736): adding location patch operation #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored from Object to JsonNode
Added new methods used to update the location data that requires no reason to be updated.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new location patch operation feature, including additional logging for R2DBC operations and supplementary tests for patch utilities and controller endpoints.
- Added DEBUG logging for R2DBC-related packages in the test resources.
- Extended PatchUtils with overloaded filtering methods and merge functionality, supplemented by new unit tests.
- Introduced PatchOperationLocationService to support location-specific patch operations and updated client codes documentation.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| legacy/src/test/resources/application-default.yml | Added DEBUG logging levels for R2DBC operations. |
| legacy/src/test/java/ca/bc/gov/app/util/PatchUtilsTest.java | Added new unit tests for merging and filtering JSON nodes. |
| legacy/src/test/java/ca/bc/gov/app/controller/ClientPatchControllerIntegrationTest.java | Added test cases for various location patch operations. |
| legacy/src/test/java/ca/bc/gov/app/controller/ClientCodesControllerIntegrationTest.java | Changed parameterized tests into simpler tests for client codes. |
| legacy/src/main/java/ca/bc/gov/app/util/PatchUtils.java | Integrated new filtering and merging methods to support patch operations. |
| legacy/src/main/java/ca/bc/gov/app/service/patch/PatchOperationLocationService.java | Created new service to handle location patch operations on client data. |
| legacy/src/main/java/ca/bc/gov/app/service/patch/PatchOperationClientService.java | Updated documentation to clarify restricted field modifications. |
Comments suppressed due to low confidence (2)
legacy/src/main/java/ca/bc/gov/app/util/PatchUtils.java:341
- "removePrefix" is invoked here but its definition is not visible in the diff. Please ensure that the method is defined or correctly imported so that the functionality works as intended.
String newPath = removePrefix(path, prefix);
legacy/src/main/java/ca/bc/gov/app/service/patch/PatchOperationLocationService.java:171
- "PatchUtils.loadIds(patch)" is called but no such method is defined in PatchUtils. Please verify whether this should reference an existing method (e.g., a pluralized version of loadId) or if an implementation should be added.
.fromIterable(PatchUtils.loadIds(patch))
|
|
|
|
mamartinezmejia
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles the location change when no reason code is required. It allows for the addition of new locations and changes in existing ones. As a reminder, primary locations cannot be expired, and this patch does not handle the expiration of locations as well, as it requires the reason code.
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: