Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fe:FSADT1-1603): CLIENT_EDITOR Client Location Section - Edit - Front-End #1428

Merged
merged 43 commits into from
Mar 7, 2025

Conversation

fterra-encora
Copy link
Collaborator

@fterra-encora fterra-encora commented Feb 28, 2025

Description

Adds the edit mode for locations, on the Client details page.
Also adds Deactivate and Reactivate actions.

Note: this feature reuses the location component built for the form to Create Client by staff. This required building a converter for the data formats, since the format used on this Client details page is different from the one used on the form to Create client.

Dedicated unit tests were added for this format converter, in both directions:

  • from the Edit format to the Create format;
  • and from the Create format to the Edit format.

Fixes FSADT1-1603

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

  • New unit tests
  • New integrated tests
  • New component tests
  • New end-to-end tests
  • New user flow tests
  • No new tests are required
  • Manual tests (description below)
  • Updated existing tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

@fterra-encora fterra-encora merged commit 341a2d3 into main Mar 7, 2025
30 checks passed
@fterra-encora fterra-encora deleted the feat/FSADT1-1603 branch March 7, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants