Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltipping helptext on technique, markings, and devices. #1478

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

AMEIJER1
Copy link
Collaborator

@AMEIJER1 AMEIJER1 commented Feb 5, 2025

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Added tooltipping to the create/edit techniques form
  • Added tooltipping to the markingsform - which is actualised on the capture and mortality edit/create form
  • Added tooltipping to the edit/add devices form.

Testing Notes

  • Noticed the HelpButtonStack for helptext tooltipping wrapped around the "Data and Information Sharing Agreement (DISA)" typography on the create survey page, and the helpbuttonstack for tooltipping on the markings button (capture and mortality edit/create page) are out of alignment. Would appreciate some guidance on the best way to correct these without misaligning other elements of the code using helpbuttonstack.
  • make fix succeeded, currently up to date with dev

@AMEIJER1 AMEIJER1 added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Feb 5, 2025
@AMEIJER1 AMEIJER1 requested a review from mauberti-bc February 5, 2025 18:57
@AMEIJER1 AMEIJER1 self-assigned this Feb 5, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (d1eb7b2) to head (b13f9f1).

Files with missing lines Patch % Lines
.../surveys/animals/profile/markings/MarkingsForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1478      +/-   ##
==========================================
+ Coverage   45.92%   46.20%   +0.27%     
==========================================
  Files         907      911       +4     
  Lines       23537    23647     +110     
  Branches     3492     3514      +22     
==========================================
+ Hits        10809    10925     +116     
+ Misses      12136    12125      -11     
- Partials      592      597       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant