Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Funding Source Amounts & Miscellanous UI tweaks #1476

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Removes all references to "amount" in funding sources
  • Drops "amount" from survey_funding_source database table
  • Various CSS tweaks

Testing Notes

  • Should be able to create/edit a survey with and without funding sources
  • NOTE: Cannot delete a Survey because of unrelated, outdated SQL

@mauberti-bc mauberti-bc added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 17.07317% with 34 lines in your changes missing coverage. Please review.

Project coverage is 46.25%. Comparing base (469a99f) to head (823bc28).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eys/components/funding/SurveyFundingSourceForm.tsx 5.00% 19 Missing ⚠️
api/src/services/survey-service.ts 0.00% 10 Missing ⚠️
...c/features/projects/view/components/TeamMember.tsx 0.00% 2 Missing ⚠️
app/src/components/fields/AutocompleteField.tsx 50.00% 0 Missing and 1 partial ⚠️
...ures/projects/view/components/TeamMemberAvatar.tsx 0.00% 1 Missing ⚠️
app/src/features/surveys/edit/EditSurveyPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1476      +/-   ##
==========================================
+ Coverage   45.92%   46.25%   +0.33%     
==========================================
  Files         907      911       +4     
  Lines       23537    23654     +117     
  Branches     3492     3511      +19     
==========================================
+ Hits        10809    10941     +132     
+ Misses      12136    12117      -19     
- Partials      592      596       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc marked this pull request as ready for review February 4, 2025 23:05
NickPhura
NickPhura previously approved these changes Feb 5, 2025
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NickPhura NickPhura added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Feb 5, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💲

@mauberti-bc mauberti-bc merged commit 5416b2d into dev Feb 5, 2025
22 of 23 checks passed
@mauberti-bc mauberti-bc deleted the misc-cleanup branch February 5, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants