Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Animal Nickname in Capture/Mortality Map Popup #1475

Merged
merged 16 commits into from
Feb 6, 2025
Merged

Conversation

AMEIJER1
Copy link
Collaborator

@AMEIJER1 AMEIJER1 commented Jan 30, 2025

Links to Jira Tickets

  • N/A

Description of Changes

  • When a capture/mortality is clicked on the map of animals on the survey page, the popup now shows the critter's nickname
  • The table animal on the survey page now includes Sex as a column

Testing Notes

@AMEIJER1 AMEIJER1 added Early Feedback Welcome PR is not finished, but early review feedback is welcomed Ready For Review PR is ready for review labels Jan 30, 2025
@AMEIJER1 AMEIJER1 requested a review from mauberti-bc January 30, 2025 20:27
@AMEIJER1 AMEIJER1 self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 46.90%. Comparing base (2e2516f) to head (afae013).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ial/components/animal/SurveySpatialAnimalTable.tsx 0.00% 15 Missing ⚠️
...ponents/animal/SurveySpatialAnimalCapturePopup.tsx 0.00% 14 Missing ⚠️
...nents/animal/SurveySpatialAnimalMortalityPopup.tsx 0.00% 13 Missing ⚠️
app/src/hooks/cb_api/useCritterApi.tsx 0.00% 3 Missing ⚠️
...-spatial/components/animal/SurveySpatialAnimal.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1475      +/-   ##
==========================================
+ Coverage   45.92%   46.90%   +0.98%     
==========================================
  Files         907      921      +14     
  Lines       23537    23818     +281     
  Branches     3492     3539      +47     
==========================================
+ Hits        10809    11173     +364     
+ Misses      12136    12044      -92     
- Partials      592      601       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc removed the Ready For Review PR is ready for review label Jan 30, 2025
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Feb 5, 2025
@mauberti-bc mauberti-bc changed the title Updating Survey Animal Table and Survey Spatial Animal Map Show Animal Nickname in Capture/Mortality Map Popup Feb 5, 2025
…/SurveySpatialAnimal.tsx


Update mortality id prop to match similar capture id prop
Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦌

Copy link

sonarqubecloud bot commented Feb 6, 2025

@mauberti-bc mauberti-bc merged commit aafa2c7 into dev Feb 6, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants