Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Import Telemetry CSV #1410

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Oct 24, 2024

Description of Changes

  • Refactors existing telemetry import tool to new format
  • Updates some types in deployment to return full record
  • New util file in telemetry-services

Testing Notes

  • Should be able to import a CSV (updated postman to include this in collection survey/file-upload/import-telemetry-csv)

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 80.85106% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@c797538). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../{projectId}/survey/{surveyId}/telemetry/import.ts 0.00% 5 Missing ⚠️
api/src/database-models/device_make.ts 0.00% 2 Missing ⚠️
...rt-services/telemetry/import-telemetry-strategy.ts 93.54% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1410   +/-   ##
=================================================
  Coverage                  ?   47.34%           
=================================================
  Files                     ?      810           
  Lines                     ?    21770           
  Branches                  ?     3195           
=================================================
  Hits                      ?    10307           
  Misses                    ?    10877           
  Partials                  ?      586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a static look over the code, looks good to me 🐘

@NickPhura NickPhura added the Ready For Review PR is ready for review label Oct 24, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@MacQSL MacQSL merged commit 324cf0b into SIMSBIOHUB-627 Oct 24, 2024
14 of 15 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-627-mdCSVTelemetry branch October 24, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants