Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Device/Deployment Frontend Changes #1409

Closed
wants to merge 4 commits into from

Conversation

NickPhura
Copy link
Collaborator

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-627

Description of Changes

Update existing deployment/device screens/forms to the new workflow.

Testing Notes

n/a

@NickPhura NickPhura changed the base branch from dev to SIMSBIOHUB-627 October 24, 2024 00:05
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 19.75806% with 199 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@c797538). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...s/telemetry/manage/devices/edit/EditDevicePage.tsx 0.00% 28 Missing ⚠️
app/src/hooks/api/useTelemetryDeviceApi.ts 3.44% 28 Missing ⚠️
...lemetry/manage/devices/create/CreateDevicePage.tsx 0.00% 21 Missing ⚠️
app/src/hooks/api/useTelemetryDeploymentApi.ts 4.76% 20 Missing ⚠️
...rveys/telemetry/manage/devices/form/DeviceForm.tsx 0.00% 12 Missing ⚠️
...p/src/features/surveys/telemetry/TelemetryPage.tsx 0.00% 10 Missing ⚠️
...mponents/telemetry/SurveySpatialTelemetryTable.tsx 0.00% 9 Missing ⚠️
...es/surveys/telemetry/list/SurveyDeploymentList.tsx 0.00% 8 Missing ⚠️
...telemetry/manage/devices/form/DeviceFormHeader.tsx 0.00% 7 Missing ⚠️
...lemetry/manage/DevicesAndDeploymentsManagePage.tsx 0.00% 6 Missing ⚠️
... and 21 more
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1409   +/-   ##
=================================================
  Coverage                  ?   47.06%           
=================================================
  Files                     ?      819           
  Lines                     ?    21868           
  Branches                  ?     3193           
=================================================
  Hits                      ?    10293           
  Misses                    ?    10991           
  Partials                  ?      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura force-pushed the SIMSBIOHUB-627-Device-Frontend branch from b26138b to 58ec82b Compare October 24, 2024 21:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura
Copy link
Collaborator Author

Will split into separate PRs

@NickPhura NickPhura closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant