Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Device Endpoints #1404

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Oct 22, 2024

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-627

Description of Changes

Add new device endpoints.

Testing Notes

I added some postman endpoints, so I've verified that the endpoints work as intended (happy path at least).

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 65.19337% with 63 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@bd8b6bb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...emetry-repositories/telemetry-device-repository.ts 5.00% 19 Missing ⚠️
...ect/{projectId}/survey/{surveyId}/devices/index.ts 61.70% 18 Missing ⚠️
...s/telemetry-repositories/telemetry-device-utils.ts 11.11% 16 Missing ⚠️
...ces/telemetry-services/telemetry-device-service.ts 25.00% 6 Missing ⚠️
...tId}/survey/{surveyId}/devices/{deviceId}/index.ts 95.31% 3 Missing ⚠️
...ct/{projectId}/survey/{surveyId}/devices/delete.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1404   +/-   ##
=================================================
  Coverage                  ?   47.14%           
=================================================
  Files                     ?      805           
  Lines                     ?    21666           
  Branches                  ?     3191           
=================================================
  Hits                      ?    10215           
  Misses                    ?    10867           
  Partials                  ?      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura requested a review from MacQSL October 22, 2024 17:51
@NickPhura NickPhura added the Ready For Review PR is ready for review label Oct 22, 2024
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩴

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@NickPhura NickPhura merged commit 8b4059f into SIMSBIOHUB-627 Oct 23, 2024
18 of 19 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-627-Device branch October 23, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants