Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Manual Telemetry CRUD #1403

Merged
merged 11 commits into from
Oct 21, 2024

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Oct 21, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@MacQSL MacQSL changed the title Simsbiohub 627 md manual telemetry SIMSBIOHUB-627: Manual Telemetry CRUD Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 49.01961% with 26 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@bd8b6bb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...emetry-repositories/telemetry-manual-repository.ts 17.39% 19 Missing ⚠️
...telemetry-services/telemetry-deployment-service.ts 16.66% 5 Missing ⚠️
api/src/database-models/telemetry_manual.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1403   +/-   ##
=================================================
  Coverage                  ?   46.89%           
=================================================
  Files                     ?      799           
  Lines                     ?    21430           
  Branches                  ?     3182           
=================================================
  Hits                      ?    10050           
  Misses                    ?    10796           
  Partials                  ?      584           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

Copy link

@MacQSL MacQSL merged commit 4e915d6 into SIMSBIOHUB-627 Oct 21, 2024
17 of 19 checks passed
@MacQSL MacQSL deleted the SIMSBIOHUB-627-mdManualTelemetry branch February 14, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants