SIMSBIOHUB-629: Paginate Sampling Sites & Separate Spatial Data in API Responses

[mauberti-bc]

Links to Jira Tickets

• https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-629

Description of Changes

• Adds a /sample-site/spatial endpoint for retrieving the geojson data for all sites in the survey
• Removes geojson property from the response when requesting all sampling sites in the survey, replacing it with a "geometry_type" string
• Paginates sampling sites on the frontend (backend pagination was already in place)
• For the sampling site accordions on the observations page, does not load accordion content until expanded
• When retrieving observations, sampling sites related to the requested observations are included in the supplementaryData object
• Removes sample site data loader from the survey context

Testing Notes

• Should not be any double requests for sampling site data
• Since sampling periods depend on the same request as sampling methods, we still need to solve sample period pagination (records shown in the sample period table are limited to those retrieved in the latest paginated sample method request).

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1393-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1393-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1393

[codecov]

Codecov Report

Attention: Patch coverage is 13.79310% with 600 lines in your changes missing coverage. Please review.

Project coverage is 45.72%. Comparing base (5203f31) to head (5e75350).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
...c/repositories/sample-location-repository/utils.ts	18.98%	64 Missing ⚠️
...rmation/sites/table/SamplingSiteTableContainer.tsx	0.00%	51 Missing ⚠️
...nts/sampling-data/SurveySamplingTableContainer.tsx	0.00%	41 Missing ⚠️
...g-information/sites/SampleSiteDataGridEditCell.tsx	2.94%	33 Missing ⚠️
...tions/sampling-sites/SamplingSiteListContainer.tsx	0.00%	32 Missing ⚠️
...-location-repository/sample-location-repository.ts	44.64%	27 Missing and 4 partials ⚠️
api/src/paths/sampling-locations/methods/index.ts	0.00%	29 Missing ⚠️
api/src/paths/sampling-locations/periods/index.ts	0.00%	29 Missing ⚠️
api/src/paths/sampling-locations/sites/index.ts	0.00%	28 Missing ⚠️
...d-column-definitions/sampling-information/utils.ts	25.71%	26 Missing ⚠️
... and 37 more

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1393      +/-   ##
==========================================
- Coverage   46.30%   45.72%   -0.58%     
==========================================
  Files         784      801      +17     
  Lines       21225    21639     +414     
  Branches     3194     3253      +59     
==========================================
+ Hits         9828     9895      +67     
- Misses      10810    11155     +345     
- Partials      587      589       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1393-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1393-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1393

[NickPhura]

Just going to change this to a draft temporarily as we are hitting the limit on our openshift resources.

[github-actions]

Openshift URLs for the PR Deployment:

• App Route: https://biohubbc-app-1393-af2668-dev.apps.silver.devops.gov.bc.ca/
• Api Route: https://biohubbc-api-1393-af2668-dev.apps.silver.devops.gov.bc.ca/
• Pods: https://console.apps.silver.devops.gov.bc.ca/k8s/ns/af2668-dev/pods?name=1393

[NickPhura]

@mauberti-bc
Okay, other than any minor CSS tweaks, etc, you might have, it should be good to go.

I'll do the other TODOs in a separate PR:

• Add pagination to the period table on the survey page.
• See if I can make the dropdown modal wider (somehow its working for the taxon/site control, but not the technique/period, even though they use the same autocomplete under the hood. But havent poked at it too hard yet)

[sonarqubecloud]

Quality Gate failed

Failed conditions
19.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[MacQSL]

Poked around the UI and it all seems happy
🦖