Set java on remote JDKs
#133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
java-bin-path
branch
from
11e73be to
f34c8c6
Compare
|
CC @tjgq @UebelAndre |
cushon
previously approved these changes
Sep 22, 2023
tjgq
reviewed
Sep 22, 2023
toolchains/jdk_build_file.bzl
Outdated
Comment on lines
86
to
88
| # Provide the 'java` binary explicitly so that the correct path is used by | ||
| # Bazel even when the host platform differs from the execution platform. | ||
| java = glob(["bin/java.exe", "bin/java"])[0], |
There was a problem hiding this comment.
Should we also:
- Document that
java_runtime.javashould (must?) be explicitly set, otherwise the default will be a guess based on the host platform? - Update the TODO in
JavaRuntime.javaaccordingly?
There was a problem hiding this comment.
(Whoops, I just noticed that this is not the main Bazel repo, but the comments still apply outside of this PR)
There was a problem hiding this comment.
- Document that
java_runtime.javashould (must?) be explicitly set, otherwise the default will be a guess based on the host platform?- Update the TODO in
JavaRuntime.javaaccordingly?
Documenting it as recommended sounds good to me.
I wonder if there's a path to making it mandatory and removing the logic for inferring it, but I'm not sure what the cleanup for that would look like.
UebelAndre
suggested changes
Sep 22, 2023
cushon
previously approved these changes
Sep 22, 2023
hvadehra
reviewed
Oct 6, 2023
If the `java` attribute on `java_runtime` isn't set, Bazel guesses it based on the host platform, which can be different from the execution platform. https://github.com/bazelbuild/bazel/blob/04a05677e4714434ec196c45a4ccbd8e0ef2f0ff/src/main/java/com/google/devtools/build/lib/rules/java/JavaRuntime.java#L46 Work towards bazelbuild/bazel#19587
hvadehra
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
javaattribute onjava_runtimeisn't set, Bazel guesses it based on the host platform, which can be different from the execution platform.https://github.com/bazelbuild/bazel/blob/04a05677e4714434ec196c45a4ccbd8e0ef2f0ff/src/main/java/com/google/devtools/build/lib/rules/java/JavaRuntime.java#L46
Work towards bazelbuild/bazel#19587