Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with incompatible_disallow_empty_glob #3621

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Build with incompatible_disallow_empty_glob #3621

merged 1 commit into from
Aug 11, 2023

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Jan 31, 2023

In order to flip the flag, all downstream projects should be adapted. However, it is hard to fix them all if there are constant regressions. Adding it to the CI will ensure that once the project can build with incompatible_disallow_empty_glob it can keep building like that.
See: bazelbuild/bazel#15327

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: bazelbuild/bazel#8195

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

gregmagolan
gregmagolan approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the fix

gregmagolan
gregmagolan previously requested changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh. This breaks CI and will require some more work before it can land from the looks of it.

@limdor limdor force-pushed the patch-1 branch 4 times, most recently from cc6b95c to e6cebd7 Compare February 16, 2023 22:27
@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jul 15, 2023
@alexeagle alexeagle changed the base branch from stable to main August 11, 2023 23:11
@alexeagle alexeagle requested a review from jbedard as a code owner August 11, 2023 23:11
@limdor @alexeagle
Build with incompatible_disallow_empty_glob
423f0b0 
In order to flip the flag, all downstream projects should be adapted.
However, it is hard to fix them all if there are constant regressions.
Adding it to the CI will ensure that once the project can build with
incompatible_disallow_empty_glob it can keep building like that.
See: bazelbuild/bazel#15327
@alexeagle alexeagle enabled auto-merge (squash) August 11, 2023 23:13
@alexeagle alexeagle requested a review from gregmagolan August 11, 2023 23:15
@alexeagle alexeagle disabled auto-merge August 11, 2023 23:16
@alexeagle alexeagle merged commit 368a3c6 into bazel-contrib:main Aug 11, 2023
alexeagle added a commit that referenced this pull request Aug 12, 2023
@alexeagle
fix(windows): unbreak CI with allow_empty
977d7df 
We had an in-flight collision between two PRs. #3679 added a cc_library, but Node.js doesn't ship the required headers on Windows, so it wouldn't work there.
#3621 disallows empty glob, which breaks because of the missing headers.
Just add the allow_empty here to make it green.
@alexeagle alexeagle mentioned this pull request Aug 12, 2023
Merged
alexeagle added a commit that referenced this pull request Aug 12, 2023
@alexeagle
fix(windows): unbreak CI with allow_empty (#3681)
f9ea4ac 
We had an in-flight collision between two PRs. #3679 added a cc_library, but Node.js doesn't ship the required headers on Windows, so it wouldn't work there.
#3621 disallows empty glob, which breaks because of the missing headers.
Just add the allow_empty here to make it green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@mattem mattem Awaiting requested review from mattem mattem is a code owner

@jbedard jbedard Awaiting requested review from jbedard jbedard is a code owner

@gregmagolan gregmagolan Awaiting requested review from gregmagolan gregmagolan is a code owner

Assignees
No one assigned
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limdor @alexeagle @gregmagolan