fix(builtin): fixes nodejs_binary to collect JSNamedModuleInfo #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasholzer
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
|
Thanks for the PR! Are you able to run |
To be backwards compatible with earlier versions still support the `JSNamedModuleInfo` provider for nodejs_binary dependencies along with the new `JSModuleInfo`. This should help dependencies to transition to the new provider without having to patch it. Fixes bazel-contrib#1998
lukasholzer
force-pushed
the
fix/nodejs-binary-named-module-provider
branch
from
1a72e4b to
9e74fe9
Compare
mattem
approved these changes
Jul 3, 2020
alexeagle
approved these changes
Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently it breaks rules that do not provide the new
JSModuleInfoinstead of theJSNamedModuleInfo,Issue Number: Fixes #1998
What is the new behavior?
To be backwards compatible with earlier versions still support the
JSNamedModuleInfoprovider for nodejs_binary dependencies along with the newJSModuleInfo.This should help dependencies to transition to the new provider without having to patch it.
Does this PR introduce a breaking change?