feat(examples): update examples/angular to new rollup_bundle #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
examples_angular_rollup_bundle
branch
2 times, most recently
from
643bd07 to
8c2f447
Compare
gregmagolan
commented
Oct 4, 2019
gregmagolan
force-pushed
the
examples_angular_rollup_bundle
branch
2 times, most recently
from
2254875 to
85b1cd1
Compare
gregmagolan
force-pushed
the
examples_angular_rollup_bundle
branch
2 times, most recently
from
dc5b2f9 to
9a9f6bc
Compare
alexeagle
reviewed
Oct 7, 2019
| - return ts_providers_dict_to_struct(ng_module_impl(ctx, compile_ts)) | ||
| + ts_providers = ng_module_impl(ctx, compile_ts) | ||
| + | ||
| + # Add in new JS providers |
There was a problem hiding this comment.
will you send the Angular PR also if you haven't already?
There was a problem hiding this comment.
already added to angular/angular#32889
| @@ -20,6 +20,8 @@ example_integration_test( | |||
| npm_packages = { | |||
| "//packages/karma:npm_package": "@bazel/karma", | |||
| "//packages/protractor:npm_package": "@bazel/protractor", | |||
| "//packages/rollup:npm_package": "@bazel/rollup", | |||
There was a problem hiding this comment.
we should add the deprecation warning in rules_nodejs now that we've shaken out issues with new rule
There was a problem hiding this comment.
I agree. follow up PR I think so we don't mix concerns.
alexeagle
approved these changes
Oct 7, 2019
gregmagolan
force-pushed
the
examples_angular_rollup_bundle
branch
from
9a9f6bc to
12241e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the new rollup_bundle will still have trouble with ng_module outputs that are non-Ivy as the generated
.ngfactory&.ngsummaryfiles have absolute imports that are not resolvable without the require patch. There is also a flaky'default' is not exportederror that shows up while bundling much of the time but not always related to the bundling the.ngfactory&.ngsummaryfiles. In short, there is some work to do to get the new rollup_bundle working with ViewEngine.Update: new rollup_bundle now working with Angular ViewEngine here #1252 with a few work-arounds in the rollup.config