Skip to content

Commit

Permalink
refactor(protractor): better naming for server runfiles in rule (#2644)
Browse files Browse the repository at this point in the history
Follow-up to 4965db6. Improves the
naming of the server runfiles depset.
  • Loading branch information
devversion authored May 7, 2021
1 parent 2a1ed31 commit 768d352
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/protractor/protractor_web_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ def _protractor_web_test_impl(ctx):
)

runfiles = [configuration] + configuration_sources + on_prepare_sources
server_files = depset()
server_runfiles = depset()

# If a server has been specified, add it to the runfiles together with it's required runfiles. This is necessary
# as the test executable references the server executable as per `TMPL_server` and executes it.
if ctx.executable.server:
server_files = depset(
server_runfiles = depset(
[ctx.executable.server],
transitive = [ctx.attr.server[DefaultInfo].default_runfiles.files],
)
Expand Down Expand Up @@ -175,7 +175,7 @@ ${{COMMAND}}
files = depset([ctx.outputs.script]),
runfiles = ctx.runfiles(
files = runfiles,
transitive_files = depset(transitive = [files, node_modules, server_files]),
transitive_files = depset(transitive = [files, node_modules, server_runfiles]),
# Propagate protractor_bin and its runfiles
collect_data = True,
collect_default = True,
Expand Down

0 comments on commit 768d352

Please sign in to comment.