refactor: use Bazel expand_location function instead of our own

This allows a mocha_test macro to be neatly written - otherwise it got inputs like wksp_name/./file.js

examples/BUILD.bazel

@@ -91,7 +91,6 @@ example_integration_test(
 example_integration_test(
     name = "examples_webapp",
     npm_packages = {
-        "//packages/jasmine:npm_package": "@bazel/jasmine",
         "//packages/protractor:npm_package": "@bazel/protractor",
         "//packages/rollup:npm_package": "@bazel/rollup",
         "//packages/terser:npm_package": "@bazel/terser",

examples/webapp/BUILD.bazel

@@ -1,7 +1,7 @@
 load("@npm//http-server:index.bzl", "http_server")
-load("@npm_bazel_jasmine//:index.bzl", "jasmine_node_test")
 load("@npm_bazel_protractor//:index.bzl", "protractor_web_test_suite")
 load(":differential_loading.bzl", "differential_loading")
+load(":mocha.bzl", "mocha_test")
 
 differential_loading(
     name = "app",
@@ -31,9 +31,12 @@ protractor_web_test_suite(
     ],
 )
 
-jasmine_node_test(
+mocha_test(
     name = "test_sourcemaps",
-    srcs = ["sourcemaps.spec.js"],
+    srcs = [
+        "sourcemaps.spec.js",
+    ],
+    entry_point = "@npm//:node_modules/mocha/bin/mocha",
     deps = [
         ":app_chunks",
         ":app_chunks.min",

examples/webapp/mocha.bzl

@@ -0,0 +1,15 @@
+"Example mocha_test macro"
+
+load("@build_bazel_rules_nodejs//:index.bzl", "nodejs_test")
+
+def mocha_test(name, srcs = [], deps = [], **kwargs):
+    nodejs_test(
+        name = name,
+        entry_point = "@npm//:node_modules/mocha/bin/mocha",
+        data = srcs + deps + [
+            "@npm//mocha",
+        ],
+        # We could mix the users args with $(locations) but what if user wants
+        # to give arg `*.spec.js` - better to stay out of the way.
+        templated_args = kwargs.pop("args", ["$(locations %s)" % s for s in srcs]),
+    )

examples/webapp/package.json

@@ -4,12 +4,12 @@
         "@babel/cli": "^7.6.0",
         "@babel/core": "^7.6.0",
         "@babel/preset-env": "^7.6.0",
-        "@bazel/jasmine": "latest",
         "@bazel/protractor": "latest",
         "@bazel/rollup": "latest",
         "@bazel/terser": "latest",
         "@bazel/typescript": "latest",
         "http-server": "^0.11.1",
+        "mocha": "^6.2.1",
         "rollup": "1.21.4",
         "source-map": "^0.7.3",
         "terser": "^4.3.1",

examples/webapp/sourcemaps.spec.js

@@ -1,5 +1,6 @@
 // Ensure we have working sourcemaps when the app runs in a browser
 
+const assert = require('assert');
 const fs = require('fs');
 const path = require('path');
 const sm = require('source-map');
@@ -38,9 +39,9 @@ function asserts(pos) {
   // so it actually starts with a bunch of '/../..'
   // expect(pos.source).toBe('index.mjs');
 
-  expect(pos.source.endsWith('index.mjs')).toBeTruthy();
-  expect(pos.line).toBe(7);     // one-based
-  expect(pos.column).toBe(20);  // zero-based
+  assert(pos.source.endsWith('index.mjs'));
+  assert(pos.line == 7);     // one-based
+  assert(pos.column == 20);  // zero-based
 }
 
 describe('application sourcemaps in the browser', () => {