Skip to content

Commit

Permalink
chore: remove unused config in bazel_integration_test
Browse files Browse the repository at this point in the history
Remove some old config params that are no longer used
  • Loading branch information
gregmagolan committed Nov 19, 2019
1 parent b7ae9ce commit 15dfec5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
6 changes: 0 additions & 6 deletions internal/bazel_integration_test/bazel_integration_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ You probably need to run
output = config,
content = """// bazel_integration_test runner config generated by bazel_integration_test rule
module.exports = {{
workspaceName: '{TMPL_workspace_name}',
packageName: '{TMPL_package_name}',
testName: '{TMPL_test_name}',
workspaceRoot: '{TMPL_workspace_root}',
bazelBinaryWorkspace: '{TMPL_bazel_binary_workspace}',
bazelCommands: [ {TMPL_bazel_commands} ],
Expand All @@ -58,9 +55,6 @@ module.exports = {{
packageJsonRepacements: {{ {TMPL_package_json_replacements} }},
}};
""".format(
TMPL_workspace_name = ctx.workspace_name,
TMPL_package_name = ctx.label.package,
TMPL_test_name = ctx.label.name,
TMPL_workspace_root = ctx.files.workspace_files[0].dirname,
TMPL_bazel_binary_workspace = ctx.attr.bazel_binary.label.workspace_name,
TMPL_bazel_commands = ", ".join(["'%s'" % s for s in ctx.attr.bazel_commands]),
Expand Down
2 changes: 0 additions & 2 deletions internal/bazel_integration_test/test_runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ function copyNpmPackage(packagePath) {
return to;
}

// testName is like examples_webapp or e2e_bazel_managed_deps
// transform to the path we expect by changing first underscore to slash
const workspacePath = config.workspaceRoot.startsWith('external/') ?
'..' + config.workspaceRoot.slice('external'.length) :
config.workspaceRoot;
Expand Down

0 comments on commit 15dfec5

Please sign in to comment.