Skip to content

Commit

Permalink
fix: _update_params
Browse files Browse the repository at this point in the history
  • Loading branch information
phi-friday committed Jul 13, 2024
1 parent 09b4010 commit b97646d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
7 changes: 1 addition & 6 deletions bayes_opt/acquisition.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,7 @@ def _l_bfgs_b_minimize(
# point technicalities this is not always the case.
return np.clip(x_min, bounds[:, 0], bounds[:, 1]), min_acq

@abc.abstractmethod
def _update_params(self) -> None:
def _update_params(self) -> None: # noqa: B027
"""Update the parameters of the acquisition function."""


Expand Down Expand Up @@ -816,8 +815,6 @@ def suggest(

return x_max

def _update_params(self) -> None: ...


class GPHedge(AcquisitionFunction):
"""GPHedge acquisition function.
Expand Down Expand Up @@ -933,5 +930,3 @@ def suggest(
self.previous_candidates = np.array(x_max)
idx = self._sample_idx_from_softmax_gains()
return x_max[idx]

def _update_params(self) -> None: ...
2 changes: 0 additions & 2 deletions tests/test_acquisition.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ def mock_acq(x: np.ndarray):
def base_acq(self, mean, std):
pass

def _update_params(self) -> None: ...


def test_base_acquisition():
acq = acquisition.UpperConfidenceBound()
Expand Down

0 comments on commit b97646d

Please sign in to comment.