Feature/improve hydration #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mloeffle
commented
Nov 28, 2024
mloeffle
commented
- reduces hydration mismatches
- refactors cookie modal
- adjust product card display to prevent overflow of form
mloeffle
requested review from
aheartforspinach,
m-borgmann and
jkniest
as code owners
m-borgmann
reviewed
Nov 29, 2024
| <CmsLoader :content="productListing" /> | ||
| <CmsLoader | ||
| :content="productListing" | ||
| class="-mx-5" |
There was a problem hiding this comment.
Not a big fan of negative margin personally. Do we really need this?
m-borgmann
approved these changes
Nov 29, 2024
jkniest
requested changes
Dec 2, 2024
There was a problem hiding this comment.
This file should not be here, since we are using Bun for all package management.
|
@mloeffle do we still need this pull request? should we continue the work on it or close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.