Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to set declaration_id when building filename from data #60

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

nbonnotte
Copy link
Contributor

The CLI dac7 name, and the function build_filename_from_xml_data() it uses, build a declaration filename from the declaration contents.

But the declaration id, that must appear in the filename, is not contained in the declaration contents.

@nbonnotte nbonnotte requested a review from a team as a code owner January 17, 2025 16:17
@nbonnotte nbonnotte merged commit 9e7360c into main Jan 17, 2025
8 checks passed
@nbonnotte nbonnotte deleted the fix/declaration_id branch January 17, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant