narwhalify SetValueTransformer #398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristinaKatsiafa
requested changes
Mar 27, 2025
| df["a"] = "a" | ||
| df["b"] = "a" | ||
| @pytest.mark.parametrize("library", ["pandas", "polars"]) | ||
| @pytest.mark.parametrize("value", ["a", 1, 1.0, None]) |
There was a problem hiding this comment.
I can see that in the transformer we allow all types and we dont have options for nans. So should we also add a missing value test here?
There was a problem hiding this comment.
yep fair point. Was kind of expecting this to break for polars but it works still! 1251699
| @@ -42,7 +48,8 @@ def __init__( | |||
|
|
|||
| super().__init__(columns=columns, copy=copy, **kwargs) | |||
|
|
|||
| def transform(self, X: pd.DataFrame) -> pd.DataFrame: | |||
| @nw.narwhalify | |||
| def transform(self, X: FrameT) -> FrameT: | |||
There was a problem hiding this comment.
Please update the docstring to match pd/pl.DataFrame
ChristinaKatsiafa
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narwhalifying SetValueTransformer for polars compatibility.
Also extending testing to cover more values being set (was previously just testing setting a string value)
Draft because for integers we get int32 return while expected is currently int64. <- edited test to cast to int32 as transformer does.