Fix file read memory leak

[SeppNel]

Fixed a memory leak in file.cpp that happened because we were storing a raw pointer in a unique pointer and never freeing it, making the unique pointer useless. This makes it so that the memory is actually handled by the unique pointer.

Before:
https://github.com/user-attachments/assets/b9bea646-71a5-4958-84c9-d287009bd0c5

You can see it increase around 3MB each transition

After:
https://github.com/user-attachments/assets/699f5b9f-84d1-443b-8c7b-e59cb36286c7

Memory still increases because of this issue but it is greatly reduced.

If we also workaround that issue:
https://github.com/user-attachments/assets/d6c009c0-ba21-4a3f-8776-db54ea10ef42

But I didn't submit that workaround since it may break games.

[PabloMK7]

Ah! I remember this. I actually did this change.
The reason I changed the u8[] is because that initializes the read buffer before reading to it. That is, it first gets memset to 0, then the data is read into it, which wastes an unneccessary initialization. I guess that making a a unique pointer of a raw pointer does not own ownership? Maybe there is a better way to prevent the initialization and not cause the memory leak.

[PabloMK7]

What about

std::unique_ptr<u8, decltype(&std::free)> buffer(
        reinterpret_cast<u8*>(std::malloc(size)), 
        &std::free
    );

[SeppNel]

I think the best choice then is make_unique_for_overwrite like so: std::unique_ptr<u8[]> data = std::make_unique_for_overwrite<u8[]>(length);
That way memory doesn't get initialized and to me it looks cleaner

[PabloMK7]

I also remember trying to use make_unique_for_overwrite, but I don't remember why I didn't use it in the end. I think it wasn't available on some platforms, let's see

[SeppNel]

All the workflows succeeded on my fork and according to this it should be well supported

[PabloMK7]

Please fix the license