Update files under dist to refer to Azahar instead of Citra #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mimetypes shouldn't be changed. |
|
@OpenSauce04 Done |
|
There is one problem I am having with these that I hope I could get some understanding. Without the patch notes, the orange blossom does indeed show in the about section: It's kind of funny, ngl, but I would like to know why. I am not a QT person at all, so I am going to look through and try my best. But, I'd figure I'd post here and see if anybody reading this knows why. |
OpenSauce04
changed the title
OpenSauce04
changed the title
|
Testing checklist:
|
This resolves some icon theming issues on Linux Co-authored-by: HurricanePootis <[email protected]>
OpenSauce04
approved these changes
Mar 21, 2025
|
@OpenSauce04 Thank you for your hard work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the mime file and icon are named
citra.xmlandcitra.svgrespectively. Furthermore, the actual MIME's arex-ctr-*. Therefore, I am proposing that (at least on Linux), to move over to usingazahar.xmlandazahar.svg, along side changing the MIME's tox-ctr-*.For me at least, one reason for doing this is that whenever using Papirus icons, whenever the
azahar.desktopfile specifiesIcon=citra, instead of showing azahar's logo from thecitra.svginstalled with the emulator, it show's Papirus' version of Citra's icon. Another reason as to consider this is to further differentiate this emulator from what came before.One thing this PR does not do is change the icon shown in the About menu, as I do not know how to do that as of right now.
I am open to feedback and comments!
Images
Before PR:
After PR: