Fix bug where log file was not generated on first run #729
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloMK7
approved these changes
Mar 19, 2025
This fix resolves issue azahar-emu#727. On first start, Log::Initialize attempts to create the `azahar-emu/log/` directory. However, it fails because `azahar-emu/` does not exist. Using FileUtil::CreateFullPath instead will create both `azahar-emu` and `log/`.
PabloMK7
force-pushed
the
bugfix/initialise-log
branch
from
5f16531 to
2deafdb
Compare
OpenSauce04
pushed a commit
that referenced
this pull request
Mar 20, 2025
* Fix bug where log file was not generated on first run This fix resolves issue #727. On first start, Log::Initialize attempts to create the `azahar-emu/log/` directory. However, it fails because `azahar-emu/` does not exist. Using FileUtil::CreateFullPath instead will create both `azahar-emu` and `log/`. * Update license header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolves issue #727.
On first start,
Log::Initializeattempts to create theazahar-emu/log/directory. However, it fails becauseazahar-emu/does not exist. UsingFileUtil::CreateFullPathinstead will create bothazahar-emu/andlog/.