-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(construct): Support for bedrock guardrail #473
Conversation
Signed-off-by: github-actions <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 92.98% 92.54% -0.44%
==========================================
Files 47 52 +5
Lines 11255 11950 +695
Branches 363 427 +64
==========================================
+ Hits 10465 11059 +594
- Misses 790 891 +101 ☔ View full report in Codecov by Sentry. |
Few comments:
|
Signed-off-by: github-actions <[email protected]>
Signed-off-by: github-actions <[email protected]>
Remaining tasks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some testing in both Ts and Python and haven't faced any issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some broken checks. Overall LGTM
Fixes #469
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.