Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing dependencies for body checksum packages #839

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from trivikr February 4, 2020 00:04
@AllanZhengYP AllanZhengYP merged commit 745caed into aws:smithy-codegen Feb 4, 2020
@trivikr
Copy link
Member

trivikr commented Feb 4, 2020

This issue was noticed earlier in #817
For this specific case, the PR where CI should have failed is #789

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #839 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #839   +/-   ##
===============================================
  Coverage           92.36%   92.36%           
===============================================
  Files                 147      147           
  Lines                2907     2907           
  Branches              508      508           
===============================================
  Hits                 2685     2685           
  Misses                222      222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50b27f1...0523be2. Read the comment docs.

@lock
Copy link

lock bot commented Feb 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants