-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup environment variable usage #763
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
==========================================
- Coverage 95.80% 92.90% -2.90%
==========================================
Files 61 71 +10
Lines 8143 9717 +1574
Branches 0 9717 +9717
==========================================
+ Hits 7801 9028 +1227
- Misses 342 421 +79
- Partials 0 268 +268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0de9cb2
to
947ed4f
Compare
b576e1e
to
a6f0995
Compare
8ec1f21
to
ef9498f
Compare
b4ab423
to
17fc27c
Compare
17fc27c
to
c9d0bef
Compare
I have tested this fix locally using my team's internal repo and confirmed that it resolves the FIPS build issues for cmake 4.0. After making the change below to my Cargo.toml file, I was able to run
Thanks @justsmth! Hope this can get merged and published soon! |
Issues:
Addresses:
aws-lc-sys
add support for customeffective_target
mappings #765Description of changes:
AWS_LC_SYS_EFFECTIVE_TARGET
environment variable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.