Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup environment variable usage #763

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 2, 2025

Issues:

Addresses:

Description of changes:

  • Improvements/fixes for how a few CI tests were setting up environment variables.
  • Fix MacOS FIPS build for CMake 4.0.
  • Support, and give preference to, target-specific environment variables.
  • Support an AWS_LC_SYS_EFFECTIVE_TARGET environment variable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (c358484) to head (c9d0bef).
Report is 200 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   95.80%   92.90%   -2.90%     
==========================================
  Files          61       71      +10     
  Lines        8143     9717    +1574     
  Branches        0     9717    +9717     
==========================================
+ Hits         7801     9028    +1227     
- Misses        342      421      +79     
- Partials        0      268     +268     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth changed the title Cleanup CI environment variable usage [DRAFT] Cleanup CI environment variable usage Apr 2, 2025
@justsmth justsmth force-pushed the cleanup-ci-env-vars branch 4 times, most recently from 0de9cb2 to 947ed4f Compare April 3, 2025 13:35
@justsmth justsmth force-pushed the cleanup-ci-env-vars branch 3 times, most recently from b576e1e to a6f0995 Compare April 3, 2025 17:24
@justsmth justsmth force-pushed the cleanup-ci-env-vars branch 3 times, most recently from 8ec1f21 to ef9498f Compare April 4, 2025 13:08
@justsmth justsmth changed the title [DRAFT] Cleanup CI environment variable usage [DRAFT] Cleanup environment variable usage Apr 4, 2025
@justsmth justsmth force-pushed the cleanup-ci-env-vars branch 3 times, most recently from b4ab423 to 17fc27c Compare April 4, 2025 17:58
@justsmth justsmth marked this pull request as ready for review April 8, 2025 12:42
@justsmth justsmth requested a review from a team as a code owner April 8, 2025 12:42
@justsmth justsmth changed the title [DRAFT] Cleanup environment variable usage Cleanup environment variable usage Apr 8, 2025
@justsmth justsmth force-pushed the cleanup-ci-env-vars branch from 17fc27c to c9d0bef Compare April 8, 2025 17:43
@sunjay
Copy link

sunjay commented Apr 10, 2025

I have tested this fix locally using my team's internal repo and confirmed that it resolves the FIPS build issues for cmake 4.0.

After making the change below to my Cargo.toml file, I was able to run cargo build successfully again.

[patch.crates-io]
aws-lc-fips-sys = { git = "https://github.com/justsmth/aws-lc-rs.git", branch = "cleanup-ci-env-vars" }

Thanks @justsmth! Hope this can get merged and published soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants