Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scheduler): schedule expression construct #25422
feat(scheduler): schedule expression construct #25422
Changes from 3 commits
5a0843d
ec40985
7f9b377
540a1ab
337b877
1d56d3b
e07a4d2
4c6abd7
98d227e
34968a2
a6fabd5
34cc3e7
10d388f
6b05925
5802931
bd7d7a1
60dcfd1
e071c26
260372b
30c8787
e874e34
2ab1af0
54b328c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another comment on impending linter errors that i feel should have been enforced somewhere: these paragraphs have to be broken into separate lines with max 150 characters i believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated readme. So the rule on characters per line in README is not enforced anywhere? What would be a good linter to add this rule to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has been enforced in the past, i think our repo restructure may have wreaked havoc on our linter perhaps. i've been meaning to look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need a disclaimer here saying that targets doesn't work yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial thoughts were to add the whole README the information about all upcoming PRs already in this first PR. We could add a notice that this is not all implemented yet but will gradually come in multiple PRs to keep the PR size smaller and reviewable. What do you think @kaizencc? Reworking the README every PR seems a but useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good with one big disclaimer :) commented that elsewhere but i just saw this