Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-ecs): include GPU & ARM based ECS optimized AMI options #2453

Merged
merged 14 commits into from
May 23, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed bug in ecs test case
  • Loading branch information
mmcclean-aws committed May 21, 2019
commit 9b55cb92fa7037bbd7be56510cff8514395a5b3f
13 changes: 2 additions & 11 deletions packages/@aws-cdk/aws-ecs/test/test.ecs-cluster.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,22 +241,13 @@ export = {
test.done();
},

"throws if amazon linux given with special HW type"(test: Test) {
"errors if amazon linux given with special HW type"(test: Test) {
// GIVEN
const stack = new cdk.Stack();
const vpc = new ec2.Vpc(stack, 'MyVpc', {});

const cluster = new ecs.Cluster(stack, 'EcsCluster', { vpc });

// WHEN
cluster.addCapacity('GpuAutoScalingGroup', {
instanceType: new ec2.InstanceType('t2.micro'),
machineImage: new ecs.EcsOptimizedAmi({
generation: ec2.AmazonLinuxGeneration.AmazonLinux,
hwType: ecs.AmiHardwareType.Gpu,
}),
});

// THEN
test.throws(() => {
cluster.addCapacity('GpuAutoScalingGroup', {
Expand All @@ -266,7 +257,7 @@ export = {
hwType: ecs.AmiHardwareType.Gpu,
}),
});
}, /Amazon Linux does not support special hardware type. Use Amazon Linux 2 instead./);
});

test.done();
},
Expand Down