Add new test/release pipelines for SDK V2 migration #605
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| - name: auto-generate-controllers |
There was a problem hiding this comment.
Not sure but it looks like there is an indentation issue here
There was a problem hiding this comment.
also the job name is conflicting with name in line 2
There was a problem hiding this comment.
i ran yq..it doesn't seem like there's indentation issues. Fixing the job name
| - aws-sdk-go-v2 |
There was a problem hiding this comment.
Do we want to run this for both aws-sdk-go-v2 and on branch tag?
There was a problem hiding this comment.
Feels like we'll have two jobs running on branch tag events
There was a problem hiding this comment.
looking further into this
michaelhtm
force-pushed
the
add-test-pipeline
branch
6 times, most recently
from
1df36a1 to
9138659
Compare
Depending on which branch a PR is created, to test and release the controller using different versions of code-gen and runtime (whether the controller is generated with aws-sdk V1 or V2) * Test
michaelhtm
force-pushed
the
add-test-pipeline
branch
from
9138659 to
fca94c1
Compare
Description of changes:
Depending on which branch a PR is created, to test and release
the controller using different versions of code-gen and runtime
(whether the controller is generated with aws-sdk V1 or V2)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.