-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QUIC buffer warning for DSN. #2195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see Golang libp2p maintainers smply don't care about Windows too much and no one volunteered to fix it, but we do want ro fiz it. Otherwise we may have connectivity issues on Windows with VPN and such. Please create upstream Rust libp2p issue about this.
Also please explain the fix for reserved peers, I don't think I understand where the issue was.
There is an issue related to the problem: libp2p/rust-libp2p#4686
As you remember, |
I thought it might have been an alternative fix for #2074. Why timeout changes then? |
Different protocol (it's reserved-peers instead of connected peers), however, I have Windows machine fully set now, and I'm going to try to reproduce it. Timeout changed because it stopped working with 1 sec likely because of the new algorithm we should have set higher value anyway because of the default delay interval. |
Doesn't sound very reliable and feels like it could break again, but if it works it is fine I guess |
Path MTU discovery seems to be broken in QUIC right now on Windows and we had to disable it in Subspace. Related: autonomys/subspace#2195. Pull-Request: #4823. Co-authored-by: Shamil Gadelshin <[email protected]>
This PR addresses the warning from
quinn
library used inlibp2p::quic
protocol that appears in DSN apps.The message consistently appears on Windows and is the result of the "path MTU discovery" process in this environment: quic-go/quic-go#3276
The PR introduces a fork for the
libp2p
framework fromv.0.52.3
. We'll likely push this fix upstream in the near future. The fix adds a configuration option forlibp2p::quic
that propagates to the underlyingquinn
library, it disables it for Windows and leaves the default configuration for other OS.The PR also contain fixes for failed test after changing the
swarm-test
dependency: introducing different delay mechanism forreserved-peers
protocol closer toconnected-peers
protocol.The alternative implementation might introduce a CLI argument for enabling/disabling "path MTU discovery".
Code contributor checklist: