Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons, splash screen and about images #371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jim-counter
Copy link
Member

Update icons, splash screen and about images.

Once the changes are confirmed good there will be a follow up PR to add Taurus and custom chain specific assets.

Copy link
Member

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also appreciate for images to be optimized (I usually just use optipng CLI tool), right now all images are 100-120% larger than their previous version, which is hard to attribute just to changed image alone.

I'd prefer Taurus and custom icons to be added right away. For .png files they should be with .taurus and .custom suffix, so icon.taurus.png. For space-acres.ico and space-acres.icns add taurus and custom icons as second and third in the same file (they are containers that supports multiple icons at once). Not sure if macOS will allow to change it in runtime, but I'll look into it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented on Slack, this is a logo, not "about" image. Note that icons were optimized for readability and this one had a larger view. It'd be nice to keep it that way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we crop to the tractor for the icon, the "T" and "C" variants will have the lettering overlap the tractor. Is an overlap acceptable or should we leave them off the icon and just use the colour shift to represent the chain?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tractor is already large enough and occupies most of the space. It should be a completely separate picture, might not even include the same tractor at all, it is just something that I did to save time for myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants