Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send props to errorHandler and loadingHandler #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zvictor
Copy link
Contributor

@zvictor zvictor commented Mar 15, 2017

I have a scenario where a parent component sends a prop down to be consumed by my container.
In the cases in that errorHandler is rendered, though, I also need to consume the same prop and it is not available.

The prop in question is used by the inner component to define its order value. Without the order value, the error component is totally misplaced.


Example:

<Blog>
  <Article id="1" order={3} />
  <Article id="2" order={1} />
  <Article id="3" order={2} />
</Blog>

If Article#3 fails and I cannot define order for its errorHandler, then it would be rendered on top, instead of the middle:

<div class="Blog">
  <div class="Article" id="1" style="order: 3" />
  <div class="Article" id="2" style="order: 1" />
  <div class="Article-error" /> <!-- doesn't contain `order` statement -->
                                <!-- will render on top -->
</div>

@AlexanderArvidsson
Copy link

Any progress on this? Would be great if this could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants