-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to use custom signing scheme and multiple keys in vtxo tree signatures #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altafan
reviewed
Jan 15, 2025
altafan
reviewed
Jan 15, 2025
altafan
reviewed
Jan 15, 2025
altafan
reviewed
Jan 15, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 16, 2025
altafan
reviewed
Jan 20, 2025
Tried to make 2 rest client settle at the same time and they crashed because of the encoding of the nonces. Seems like some elems of the matrix are nil when signing a branch. |
altafan
reviewed
Jan 29, 2025
altafan
reviewed
Jan 29, 2025
altafan
reviewed
Jan 29, 2025
altafan
reviewed
Jan 29, 2025
Co-authored-by: Pietralberto Mazza <[email protected]> Signed-off-by: Louis Singer <[email protected]>
Co-authored-by: Pietralberto Mazza <[email protected]> Signed-off-by: Louis Singer <[email protected]>
altafan
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way for the user to sign only its branch during the vtxo tree signing process.
now
RegisterOutputsForNextRound
RPC expects the following request:ephemeral_pubkey
has been replaced bymusig2.cosigners_public_keys
. It allows setting multiple signing keys for the same request. Useful for collaborative VTXO contracts.signing_type
is a flag signalling to the server the type of signing scheme the user wants to use, 2 are supported:SignAll = 0
is the existing scheme where one signs all branches of the tree.SignBranch = 1
is the new scheme where one signs only the branch(es) related to his VTXO(s) in the tree.BREAKING CHANGES:
With this, the tree's PSBTs don't embed the sweep tapscript leaf and internal taproot key as unknown fields anymore. They are replaced instead with the batch lifetime, as clients know all other info to reconstruct the sweep leaf on their own.
@tiero @altafan @sekulicd please review