Agnostic VtxoScript + migrate from descriptor to script array
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altafan
reviewed
Nov 19, 2024
tiero
reviewed
Nov 19, 2024
tiero
reviewed
Nov 19, 2024
* Hotfix: Prevent ZMQ-based bitcoin wallet to panic (ark-network#383) * Hotfix bct embedded wallet w/ ZMQ * Fixes * Rename vtxo is_oor to is_pending (ark-network#385) * Rename vtxo is_oor > is_pending * Clean swaggers * Revert changes to client and sdk
altafan
approved these changes
Nov 20, 2024
sekulicd
pushed a commit
that referenced
this pull request
Nov 21, 2024
* migrate descriptors --> tapscripts * fix covenantless * dynamic boarding exit delay * remove duplicates in tree and bitcointree * agnostic signatures validation * revert GetInfo change * renaming VtxoScript var * Agnostic script server (#6) * Hotfix: Prevent ZMQ-based bitcoin wallet to panic (#383) * Hotfix bct embedded wallet w/ ZMQ * Fixes * Rename vtxo is_oor to is_pending (#385) * Rename vtxo is_oor > is_pending * Clean swaggers * Revert changes to client and sdk * descriptor in oneof * support CHECKSIG_ADD in MultisigClosure * use right witness size in OOR tx fee estimation * Revert changes --------- Co-authored-by: Pietralberto Mazza <[email protected]>
altafan
added a commit
that referenced
this pull request
Nov 22, 2024
* wasm e2e test * Remove ark-sdk.wasm.gz from repository * pr review * exclude test files from linting * fix * test fix * go work sync * gha fix * gha fix * wasm e2e test * kill webserver * Fix nonce encoding/decoding & Fix pop from queue of payment requests (#375) * bug fix - paymentMap pop input traversal * bug fix - nonce encode/decode * pr review * pr review * Fix trivy gh action (#381) * Update trivy gha * Update tryvy gha * Fix * merge * Panic recovery in app svc (#372) * panic recovery * pr review * Support connecting to bitcoind via ZMQ (#286) * add ZMQ env vars * consolidate config and app-config naming * [Server] Validate forfeit txs without re-building them (#382) * compute forfeit partial tx client-side first * fix conflict * go work sync * move verify sig in VerifyForfeits * move check after len(inputs) * Hotfix: Prevent ZMQ-based bitcoin wallet to panic (#383) * Hotfix bct embedded wallet w/ ZMQ * Fixes * Rename vtxo is_oor to is_pending (#385) * Rename vtxo is_oor > is_pending * Clean swaggers * Change representation of taproot trees & Internal fixes (#384) * migrate descriptors --> tapscripts * fix covenantless * dynamic boarding exit delay * remove duplicates in tree and bitcointree * agnostic signatures validation * revert GetInfo change * renaming VtxoScript var * Agnostic script server (#6) * Hotfix: Prevent ZMQ-based bitcoin wallet to panic (#383) * Hotfix bct embedded wallet w/ ZMQ * Fixes * Rename vtxo is_oor to is_pending (#385) * Rename vtxo is_oor > is_pending * Clean swaggers * Revert changes to client and sdk * descriptor in oneof * support CHECKSIG_ADD in MultisigClosure * use right witness size in OOR tx fee estimation * Revert changes --------- Co-authored-by: Pietralberto Mazza <[email protected]> * fix unit test * fix unit test * fix unit test --------- Co-authored-by: Pietralberto Mazza <[email protected]> Co-authored-by: Marco Argentieri <[email protected]> Co-authored-by: Louis Singer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace descriptor by tapscripts array
Since descriptors don't yet support timelocks, we are currently using a custom descriptor lib maintained by us. This is cool but the package is basically just a list of supported descriptor templates, not something that is general-purpose and ready-to-use and requires us to update this list for any custom script created by the client, while we designed the Server to support any kind of script.
Therefore, instead of using our custom
descriptorpackage to represent a taproot tree, we now use a list of hex-encoded raw taproot tree leaves, allowing any custom script client-side without having to touch anything server-side.Agnostic
VtxoScriptDefaultVtxoScripthas been replaced byTapscriptsVtxoScriptaccepting a set of taproot scripts instead of hardcoding the script types.MultisigClosureandCSVSigClosurenow accept a list of keys instead of a hardcoded number of keys. It allows building custom forfeit and exit closures.ARK_EXIT_DELAY.@altafan @tiero please review